Skip to content

(maint) Correct CFPropertlyList platforms, replace deprecated Windows platforms#633

Merged
david22swan merged 2 commits into
mainfrom
maint/main/cfpropertylist
May 5, 2026
Merged

(maint) Correct CFPropertlyList platforms, replace deprecated Windows platforms#633
david22swan merged 2 commits into
mainfrom
maint/main/cfpropertylist

Conversation

@mhashizume

Copy link
Copy Markdown
Contributor

Summary

This PR does two things:

  • Limits the CFPropertyList gem to macOS instead of Windows, as it is a macOS-specific gem.
  • Replaces deprecated Windows platforms (mswin, mingw) with windows (see: ruby/rubygems@0ca6dc3).

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

The CFPropertyList gem, which manages macOS property list (plist) files,
was erroneously limited to only Windows platforms. This commit updates
the default configuration to set CFPropertyList to only be installed on
macOS platforms in the Gemfile.
Bundler has deprecated mswin and mingw platforms in favor of windows
(see: ruby/rubygems@0ca6dc3). This commit updates config defaults to use
windows.
@mhashizume mhashizume requested a review from a team as a code owner April 24, 2026 16:50

@david22swan david22swan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ran this through the pdk pipeline and it cleared fine

@david22swan david22swan merged commit c3f4bf4 into main May 5, 2026
2 checks passed
@david22swan david22swan deleted the maint/main/cfpropertylist branch May 5, 2026 12:44
@david22swan

Copy link
Copy Markdown
Member

@mhashizume Would you mind updating the PR title so that the changes come through clearer on the changelog when it is generated?

@mhashizume mhashizume changed the title (maint) Gemfile housekeeping (maint) Correct CFPropertlyList platforms, replace deprecated Windows platforms May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants