(maint) Correct CFPropertlyList platforms, replace deprecated Windows platforms#633
Merged
Conversation
The CFPropertyList gem, which manages macOS property list (plist) files, was erroneously limited to only Windows platforms. This commit updates the default configuration to set CFPropertyList to only be installed on macOS platforms in the Gemfile.
Bundler has deprecated mswin and mingw platforms in favor of windows (see: ruby/rubygems@0ca6dc3). This commit updates config defaults to use windows.
david22swan
approved these changes
May 5, 2026
david22swan
left a comment
Member
There was a problem hiding this comment.
LGTM
Ran this through the pdk pipeline and it cleared fine
Member
|
@mhashizume Would you mind updating the PR title so that the changes come through clearer on the changelog when it is generated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR does two things:
mswin,mingw) withwindows(see: ruby/rubygems@0ca6dc3).Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist